tilgovi commented on pull request #88: URL: https://github.com/apache/incubator-annotator/pull/88#issuecomment-689016825
This looks good. I think I'm okay with removing the relative import rule for now. I don't like having modules called `util`, or packages called `common` or `utils` or anything like this, much, though. I would prefer to leave it in a file called `scope.ts`. I might wish to flatten everything a bit. I understand you like grouping relating things, but I don't mind longer files for groupings or filename prefixes. We have a monorepo so that we can make many packages easily. For any of those packages to have much internal hierarchy or structure feels wrong to me. Having the parent relative imports feels like we haven't given things the right structure. We should be able to easily make a package, like `@annotator/dom-range` to have range related utilities, or simply `@annotator/dom` to have DOM-related utilities. For this reason, I think I would prefer to just inline the two lines of `ownerDocument()` and then do that separately. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
