tilgovi commented on pull request #100:
URL: 
https://github.com/apache/incubator-annotator/pull/100#issuecomment-761939408


   With no tagging and no pushing there should be no need for token in the `git 
remote` step. In fact, the remote might already be configured (as `origin`, 
read-only) and there may be no need for the remote step at all. That might only 
be necessary for packages that are trying to push the tag back to GitHub, but 
I'm not sure I see a strong reason to since the that version number that gets 
published contains a short sha of the current commit on master (not a commit 
after bumping the version numbers).
   
   Let's simplify and make it part of the deploy steps. This might work:
   
   ```
   deploy:
     - provider: script
       script:
         - git checkout master
         - npx lerna publish --preid dev --dist-tag dev --canary --yes
       skip_cleanup: true
       on:
         branch: master
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to