tilgovi commented on a change in pull request #110:
URL:
https://github.com/apache/incubator-annotator/pull/110#discussion_r645887503
##########
File path: packages/dom/src/css.ts
##########
@@ -45,21 +46,17 @@ import { ownerDocument } from './owner-document';
* > “If […] the user agent discovers multiple matching text sequences, then
the
* > selection SHOULD be treated as matching all of the matches.”
*
- * Each matching element is returned as a {@link
https://developer.mozilla.org/en-US/docs/Web/API/Range
- * | Range} surrounding that element. This in order to make its output reusable
- * as the scope for any subsequents selectors that {@link
- * Selector.refinedBy | refine} this CssSelector.
- *
- * @param selector - The {@link CssSelector} to be anchored
- * @returns A {@link Matcher} function that applies `selector` to a given
{@link https://developer.mozilla.org/en-US/docs/Web/API/Range
- * | Range}
+ * @param selector - The {@link CssSelector} to be anchored.
+ * @returns A {@link Matcher} function that applies `selector` to a given
+ * `scope`.
*
* @public
*/
export function createCssSelectorMatcher(
selector: CssSelector,
-): Matcher<Range, Range> {
+): Matcher<Node | Range, Element> {
Review comment:
This is the only part that worries me. It feels a little like this
should be symmetrical for some reason, but I'll think more on it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
