Treora commented on issue #113:
URL:
https://github.com/apache/incubator-annotator/issues/113#issuecomment-913777213
Regarding replacing the `optimal-select` dependency, I described my earlier
research in commit message c8ef340e34b1:
I tried a few css selector generators, listed here:
<https://github.com/fczbkk/css-selector-generator-benchmark>
- css-selector-generator failed when a root (= scope) is passed; see
issue <https://github.com/fczbkk/css-selector-generator/issues/65>.
- using @mdev/finder instead gave syntax errors due to ‘export’ token.
(perhaps because we don’t transpile dependencies; worth considering?)
- optimal-select seemed to work; whatever works is good enough for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@annotator.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
