tilgovi commented on a change in pull request #116:
URL: 
https://github.com/apache/incubator-annotator/pull/116#discussion_r747279515



##########
File path: scripts/verify-rc.sh
##########
@@ -0,0 +1,52 @@
+set -e
+
+#VERSION=0.2.0

Review comment:
       We can remove these comments.

##########
File path: scripts/verify-rc.sh
##########
@@ -0,0 +1,52 @@
+set -e
+
+#VERSION=0.2.0
+#RC=1
+
+if [ -z "$VERSION" ] || [ -z "$RC" ]
+then
+  echo "First set the VERSION and RC environment variables."
+  exit 1
+fi
+
+gpg --verify apache-annotator-*.tar.gz.asc
+
+sleep 5
+
+sha256sum --check apache-annotator-*.tar.gz.sha256
+sha512sum --check apache-annotator-*.tar.gz.sha512
+
+sleep 5
+
+tar xzf apache-annotator-$VERSION-rc.$RC-incubating.tar.gz
+cd apache-annotator-$VERSION-incubating
+
+git remote show origin
+
+sleep 5
+
+git fetch --unshallow origin tag v$VERSION-rc.$RC
+
+git describe
+
+sleep 5
+
+git status --ignored
+
+sleep 5
+
+# Expects Apache RAT 0.13 jar to be present in home directory
+# wget https://dlcdn.apache.org/creadur/apache-rat-0.13/apache-rat-0.13-bin.zip
+# unzip apache-rat-0.13-bin.zip
+java -jar ~/apache-rat-0.13.jar -E .ratignore -d .

Review comment:
       Do you think we should just download rat here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@annotator.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to