Treora opened a new pull request, #138: URL: https://github.com/apache/incubator-annotator/pull/138
We have discussed similar APIs before, to make the common use cases easier. - `createAnySelectorMatcher` mimics the signature of existing matcher creators, but works on any selector type we support. For tools that try to maximise interoperability, matching a selector of any supported type should be easy; checking the type and using the right matcher is a task we can do for the user. - `matchSelector` wraps the this to make the common use case easy, hiding the generator and returning an array instead. Until they get advanced needs, a user should not have to care about async generators and curried functions to anchor a selector. Especially so as our highlighter messes up the matcher when used before the latter is finished (see issue #112). Note this code depends on (and already includes the commits of) #136 and #137. When trying to run `yarn start`, I get an error about missing imports, so probably I messed something up still.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@annotator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
