Github user BigBlueHat commented on a diff in the pull request:
https://github.com/apache/incubator-annotator/pull/3#discussion_r115522283
--- Diff: scripts/serve.js ---
@@ -39,19 +39,16 @@ const packages = fs.readdirSync(packagesPath);
const app = express();
-packages.forEach((name) => {
+packages.forEach(name => {
const root = path.join(packagesPath, name);
const entry = path.join(root, 'index.js');
const dest = path.join(root, `${name}.bundle.js`);
- const external = (id) => /^@(annotator|hot)/.test(id);
+ const external = id => /^@(annotator|hot)/.test(id);
--- End diff --
Is the removal of parens from them `google` presets? I actually rather like
having them around as I find hunting for the extra `>` in a line tedious.
But again...mailing list? :wink:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
