tilgovi commented on issue #22: Build a highlighter URL: https://github.com/apache/incubator-annotator/issues/22#issuecomment-348373026 I take that back. I would rather not commit to any tag choice at all right now and just spend some time mulling over what problem(s) really need solving. Here are some more formed thoughts that have come up for me in the past: Q: How to denote things added by the annotation layer A: TDB, but also maybe just doesn't matter to some selectors Q: How to visualize style / modify the DOM A: TDB, but generally requires iterating over the text nodes for text use cases Q: How do we iterate over all the text nodes? A: `NodeIterator`, which I even built a polyfill for: https://github.com/tilgovi/dom-node-iterator I think we need to sketch a couple highlighter implementations and play with them.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
