Treora commented on issue #25: error: context not equal to range's container
URL: 
https://github.com/apache/incubator-annotator/issues/25#issuecomment-358412575
 
 
   > I'm not sure if this isWithinNode() method is solely for the demo's 
selection box, or if something like that is always needed when using the 
underlying library.
   
   It is needed in the demo, because the (content of) the `#selectable` text 
box is regarded as the 'document' we are annotating (and the `#corpus` box next 
to it is the document the annotation is reapplied to). Passing a range that 
falls outside the document you are working in seems generally invalid. So the 
`isWithinNode` check is done because we pass the contents of `#selectable` as 
the `context` to `describeRange`.
   
   The actual issue here is more or less the other way around: if the 
context/'document' is larger than a single text node, e.g. the whole 
`document.body`, things should of course work fine, but that (most usual) 
situation not yet implemented.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to