On 6/23/19 2:15 AM, Randall Leeds wrote: > […] > > Questions for Library Authors > > Gerben, would you be interested in bringing dom-highlight-range into > the project? We have an open issue [4] to build a highlighter. > Benjamin and I discussed at I Annotate that it would be immensely > valuable for users to have even a simple implementation. Your project > is already a dependency of the Apache Annotator demo, and its LICENSE > [5] credits dom-anchor-text-position.
Sure, I’d be happy to group such modules under the Annotator umbrella. I agree it is valuable to have a highlighting tool available off-the-shelf (‘batteries included’), even if it may not be as generic/unopinionated as we would like other ‘core’ modules to be. I would not mind changing the name if that would be desired. Also both the API and implementation of the module could use some revision (I think this was my very first javascript module), but that could also happen after adopting it (e.g. use <mark> instead of <span>, make it an ES6 module, possibly return an object rather than just a cleanup function, …). > […] As for the mentioned modules approx-string-match-js, dom-node-iterator, dom-seek, dom-anchor-text-position; > > Licensing Questions > […] > In the case of dom-highlight-range, Gerben is the sole author. A piece of it was copied from you (Randall). The rest I put out in the public domain, I hope that simplifies things. > […]
