Treora opened a new pull request #62: Use highlighter in demo URL: https://github.com/apache/incubator-annotator/pull/62 Use `highlightRange` from the dom package in the demo instead of the custom implementation. Also use its `removeHighlight` callbacks instead of just replacing the element’s innerHTML to clean up the highlights. Note that text nodes that are split by the highlighter will remain split after a `cleanup()`. This reveals a bug in our matching functions, as the “any deeper nesting” example now fails to find any matches (except at a first try, when the text nodes are not yet split).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
