+1 On Tue, Mar 10, 2020, 23:09 Gerben <ger...@treora.com.invalid> wrote:
> +1 > On 10/03/2020 16:09, Benjamin Young wrote: > > +1 from me--with huge gratitude to Randall for making this all happen!! :D > > The signature and sha's all checked out fine. My local diff (on Windows) has > line ending differences (which I know about...per my git config). My diff > also shows the following files in the git checkout which are not in the > tarball--all of which I think are fine, but wanted to confirm and/or document > for future comparison/checks. > > Files in local git checkout which are not in the tarball include: > - .git/ (as for Randall) > - .nyc_output/ (probably due to a different reporter I used at some point) > - node_modules/ (we don't ship this in the tarball...nor should we afaik) > - packages/fragment-identifier/node_modules/ (same as above) > - packages/fragment-identifier/src/fragment.js (...not sure about this > one...) > > Everything else is identical (ignoring line endings--per platform > differences). > > Any thoughts (or explanations) about the fragment.js situation? > > fragment.js is not source code, but generated from fragment.pegjs. It is > created when building/running the code, just like node_modules/ and other > folders and files (I moreover see an esm/, lib/, LICENSE and NOTICE in each > package folder). > > For an easier comparison, you could make a fresh clone of your repository > into a new folder (e.g. run `git clone incubator-annotator/ > incubator-annotator-clean/`), and compare the sameness with that one > instead. And then perhaps build and run it to validate whether it also > works correctly. > > … > >
