On Thu, 19 Mar 2020 18:07:08 -0000 GitBox <g...@apache.org> wrote: > BigBlueHat opened a new pull request #66: Improve licensing > URL: https://github.com/apache/incubator-annotator/pull/66 > > > Fix #63 > > This *should* be what's needed to properly record the licensing on > the `fragement.pegjs` and the generated (and potentially bundled?) > `fragment.js` file.
Is that where the problem lay? I hope we're not treating a generated file as a source file? > Actions: > - added [W3C Software and and Document > License](https://www.w3.org/Consortium/Legal/2015/copyright-software-and-document) > text to LICENSE and called out the above files (which this license > covers) Um, that looks literal. Doing anything to LICENSE is absolutely not what's needed here! > - left the related notice content in NOTICE (per the W3C's > license...and just for added clarity) > - added [the license and author declaration comments from the > original generated > `fragment.js`](https://github.com/w3c/web-annotation/blob/gh-pages/selector-note/converter/fragment.js#L1-L2) > to our copy of `fragment.pegjs` (which is the source file) Apache Rat > still complains that this W3C license is not yet approved... That looks more likely to be the underlying issue. Can you elaborate on "still complains"? > > Files with unapproved licenses: > > ./packages/dom/src/highlight-range.js > > ./packages/fragment-identifier/src/fragment.pegjs I think what Justin was looking for was a disclaimer about this being work in progress with such issues still to be sorted. https://www.mail-archive.com/general@incubator.apache.org/msg69806.html -- Nick Kew
