DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19897>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19897 Patch to implement the namespaced antlib + other changes ------- Additional Comments From [EMAIL PROTECTED] 2003-06-04 09:24 ------- It would be good to get some feedback from Conor McNeill and from Costin Manolache concerning your latest patch. My personal +1 with the following remarks : JavaDoc comments in TypeAdapter.java ------------------------------------- setProxy(Object o) instead of : "Sets the target object to proxy for." would prefer "Sets the proxy object, whose methods are going to be invoked by ant" Similarly for getProxy "Returns the target object being proxied." does not mean anything to me. I would suggest simply "Returns the proxy object" Name of field "assignableClass" in AntTypeDefinition.java would it not be better to call it also "adaptToClass", so that it matches with Definer.java ? This line of your code : def.setAssignableClass(adaptToClass); line 446 of Definer.java suggests that assignableClass is the same as adaptToClass, or did I miss something ? I also wonder whether assignableClass and adaptToClass are not both synonyms for roleClass ? Apart from these 2 remarks, I personally would be very happy to see your code committed, because it is certainly going to add a lot of value to ant, and I am eager to see ant 1.6 rolling.
