Hi Filip, it is good that you show up.
I would suggest that you do the following for each of your fixes : - check that your problems are not already fixed in ant1.6beta3 - open a bugrep in bugzilla for each problem, and attach your patch there - if you are worried that your changes are not going to be committed fast enough, create bugreps for the 2 highest priority problems first, see how it goes, and then enter the rest. I find it good that you add Fileset support to cvs, actually, it is a surprise that this does not exist yet. Why does it only work one directory deep ? Concerning scp and ftp, if your patches are of good quality, this should be no problem. By the way, I fixed one NPE in ftp between ant1.6beta2 and ant1.6beta3 (bugrep 24440). I have seen that you have opened a bugrep 25032. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25032 Concerning unjar, the jar entry beginning with / is not very much in the typical fileset philosophy of ant. Your patch should unjar to /file.txt to dest/file.txt only if a new attribute "acceptrootfiles" or something like this is set to yes. Here again other committers might see it differently. Concerning main, if you are embedding ant, you could write this type of code snippet : public class testregexp { public static void main (String [] argv){ Diagnostics.validateVersion(); //String filename="/dev/testant/build.xml"; String filename="/dev/testant/regexp.xml"; StringBuffer logBuffer; StringBuffer fullLogBuffer; Project project=new Project(); logBuffer = new StringBuffer(); fullLogBuffer = new StringBuffer(); project = new Project(); project.init(); project.setUserProperty( "ant.file" , new File(filename).getAbsolutePath() ); ProjectHelper.configureProject(project, new File(filename)); project.addBuildListener(createLogger()); //project.executeTarget("cleanup"); project.executeTarget("filter"); } private static BuildLogger createLogger() { BuildLogger logger = null; logger = new DefaultLogger(); logger.setMessageOutputLevel(Project.MSG_VERBOSE); logger.setOutputPrintStream(System.out); logger.setErrorPrintStream(System.err); logger.setEmacsMode(false); return logger; } } I am not too keen on adding one more command line option to Main. (but this is just me, the other committers might think differently) Cheers, Antoine -----Ursprüngliche Nachricht----- Von: Filip Hanik [mailto:[EMAIL PROTECTED] Gesendet: Montag, 8. Dezember 2003 22:29 An: Ant Developers List Betreff: bug fixes!! WAS: ant 1.6beta3 released I have fixes for the following tasks: 1. SCP - this task hangs on large file transfers, I have added in a batch size which issues new SCP command for each X tasks. This allows me to transfer over 2000 files between our servers. 2. CVS - the line "cvs add *" doesn't work, I have added in <fileset> element to CVS which allows you to add files to the command line for all commands, works with update delete add etc, only one level deep directory 3. FTP - I have a file parser for Windows FTP servers, modified the FTP task to take a parameter for which OS the FTP server is. Even better would be if it could auto detect. Also fixed nullpointer bug if the remote directory doesn't contain any files and a ls is issued. 4. Main, changed it so that it wouldn't issue a System.exit if a flag is passed in, this is necessary for us since we are launching ant embedded and don't want to install an additional security manager. 5. Unzip,unjar currently doesn't work when the file listing is "/file.txt" inside the jar. Even if you give the unjar command a destination directory, it tries to save the file in the root directory. I fixed this as well! I have fixes for all of these. Since it is gonna take me about 2 hours to create PATCH files, I wanted to check in with the developers here that if I spend the time, this will get committed. thanks Filip --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
