Stefan Bodewig wrote:

On Thu, 11 Dec 2003, Peter Reilly <[EMAIL PROTECTED]> wrote:



On looking at the fileset issue again, the debug statement was
present in ant 1.5 as well, however in ant 1.5, the fileset did not
have a toString method.



So, if you wrap a <path> around your <fileset> and id the <path>, is 1.5 as slow as 1.6? Should be.



Good catch.

<project default="calls">
 <path id="set">
   <fileset  dir=".">
     <include name="**/*.xml"/>
   </fileset>
 </path>
 <target name="y">
 </target>
 <target name="calls">
   <antcall target="y"/>
   <antcall target="y"/>
   <antcall target="y"/>
   <antcall target="y"/>
   <antcall target="y"/>
   <antcall target="y"/>
   <antcall target="y"/>
   <antcall target="y"/>
   <antcall target="y"/>
   <antcall target="y"/>
 </target>
</project>

ant 1.5 0:17.91elapsed
ant 1.6 0:05.38elapsed
patched ant 1.6 0:01.04elapsed


I would suggest to remove the warning (when the reference is used a
warning will be provided anyway) and change the debug log to

log("Adding reference: " + name, MSG_DEBUG);



+1

this also fixes the "Caught exception wile expanding ..." confusion as
people read this as a build failure rather than an informational
message.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]







---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to