> From: Antoine Lévy-Lambert [mailto:[EMAIL PROTECTED] > > Jose Alberto Fernandez wrote: > > >Given the realization of Peter, maybe we need to embark on > >a code review of the tasks, at least the most important > >to make sure we do not keep hold or objects unnecessarily. > > > >If you look at the memory utitization numbers I submitted > >all of them are like much larger, even before the first > script gets to > >be ran. I think it may have to do with this issue. > > > I realized that tasks are never GCed because there was a > bugzilla report > about the <propertyfile/> task. > http://nagoya.apache.org/bugzilla/show_bug.cgi> ?id=21505 > > ... > > Because of these type of issues, a number of tasks which in > the execute > method are changing instance variables are resetting these instance > variables at the end of the execute method. > > There are lots of constructs like : > > public void execute() { > > savedProperty1 = property1; > savedProperty2 = property2; > > /* do something */ > > property1 = savedProperty1; > property2 = savedProperty2; > > } > > This does not look too nice and might not be entirely foolproof - in > case of exceptions happening somewhere in the execution of > the task for > instance, and not allowing the instance variables to be > resetted to their values prior to execution. >
Was this the case in 1.5.x ? Or is it due to some change on how we build the project now? If the later, is there a way to simulate the previous behavior? For example by removing the <task> instance and recomputing the UnknownObject every time. I still do not understand the situation Antoine found with <propertyfile/> because I thought that everytime <ant[call]/> gets executed a complete new project instance gets constructed, executed and thrown away. So a task should never be reused due to repeated calls to <antcall/>. Am I mistaken? Was something dramatically changed? Jose Alberto --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
