Then I will add that again :) Or would it be better to add the if/unless to <patternset>, I think so?
Jan > -----Original Message----- > From: Peter Reilly [mailto:[EMAIL PROTECTED] > Sent: Friday, February 27, 2004 1:15 PM > To: Ant Developers List > Subject: Re: Ant build.xml: run "teststhatfail" > > > [EMAIL PROTECTED] wrote: > > >The target "run-tests" excludes the patternset > "teststhatfail" from being > >executed. The comment sais, that I can force running them by > setting the > >property "run.failing.tests". But I havenīt found any > reference to that > >name inside the build file. > > > >Is there something build-in in the <junit> task or is there something > >missing in > >the buildfile (e.g. the unless-clause in the <exclude>s on > line 330/331)? > > > > > Looks that that should be the case. Looking at the history of > build.xml, > at one stage the testthatfailed reference had this unless class in the > excludes, > http://cvs.apache.org/viewcvs.cgi/*checkout*/ant/build.xml?con tent-type=text%2Fplain&rev=1.290 and at one stage there was no tests that failed, soon afterwards, one was added back in (the beanshell one) but this did not have the excludes clause. Peter > >Jan > > > > 329: <patternset id="teststhatfail"> > 330: <exclude name="${optional.package}/BeanShellScriptTest.java"/> > 331: <exclude name="${optional.package}/jdepend/JDependTest.java"/> > 332: </patternset> > >1414: <target name="run-tests" ... >1426: <junit ... >1440: <batchtest> >1441: <fileset dir="${tests.dir}"> >1442: <include name="**/*Test*"/> >1468: <!-- failing tests excluded unless run.failing.tests is set >--> >1469: <patternset refid="teststhatfail"/> > > > > >--------------------------------------------------------------------- >To unsubscribe, e-mail: [EMAIL PROTECTED] >For additional commands, e-mail: [EMAIL PROTECTED] > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
