DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=30517>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=30517 [signjar] : uptodate enhancements Summary: [signjar] : uptodate enhancements Product: Ant Version: 1.6.2 Platform: Other OS/Version: Other Status: NEW Severity: Enhancement Priority: Other Component: Core tasks AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] 1.There is some dead code in SignJar.java In the method 'isSigned(File file)' there is the code : if (null == alias) { Enumeration entries = jarFile.entries(); while (entries.hasMoreElements()) { String name = ((ZipEntry) entries.nextElement()).getName(); if (name.startsWith(SIG_START) && name.endsWith(SIG_END)) { return true; } } return false; } The 'alias' variable is a required attribute and can never be null at this point. the code in the if statement is never executed and can be removed. 2. The detection of a file that is signed looks for the file SIG_START + alias.toUpperCase() + SIG_END it would be nice if the attribute 'internalsf' is set and 'sigfile' is NOT set then : Set the attribute 'sigfile' to "SIG_START + alias.toUpperCase() + SIG_END" --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
