DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=31930>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=31930 Zip & Unzip tasks major slowdown ------- Additional Comments From [EMAIL PROTECTED] 2004-11-09 06:58 ------- Just looking again, and the method toDosTime() get's called frquently and returns a ZipLong, each time it's used (in only two places), the ZipLong is queried to extract the bytes (getBytes()). Why not simply return a byte array and save the needless method call? - is toDosTime() called anywhere else in the code (it doesn't seem to be)? - is there a code convention where we must always return an object? Also the change I made to remove deprecated (Date) code, means that a new calendar instance is retrieved each call to toDosTime(). Making the calendar a class variable would save another method call. Small things like this *may* help, but again, there could be a much larger problem that I'm not aware of as I've only just started looking at the code base. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]