> From: Stefan Bodewig [mailto:[EMAIL PROTECTED] > On Wed, 9 Mar 2005, Matt Benson <[EMAIL PROTECTED]> wrote: > > --- Stefan Bodewig <[EMAIL PROTECTED]> wrote: > > >> Then we could add another implementation of FileCollection that's > >> much like FileSet but doesn't require a basedir. > > > > Then wouldn't it still be easiest to extend AFS and move the > > "dir-not-null" checks to DirSet and FileSet, or to a second abstract > > DirbasedFileSet class and change DirSet and FileSet to extend that? > > Works for me - either approach.
Well... setDir(File dir) is still on AFS. We can't get it out for BC, and having it there makes it visible to IH. Yes, you can throw in the FileBag (;-), but it's still visible to the FileBag API, when it really shouldn't be. I wouldn't -1 extending AFS, but I don't see it as clean. I'm -0 then. --DD --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
