--- Conor MacNeill <[EMAIL PROTECTED]> wrote:
> Kevin,
>
> I had a quick look at thi spatch and not sure I
> agree with some thigns
> in it.
>
> I'm not sure I understand the motivation for this
> name hiding stuff.
> Changing variable names from "password" to "pass" or
> "daemonTasks" to
> "dTasks" does not strike me as being an improvement.
I believe these are responses to Jikes' complaining
about shadowed instance variables.
>
> Likewise, I do not see converting an if-else to a
> ternary conditional
> makes the code clearer - on the contrary it makes it
> more convoluted.
Ternary conditionals are one of my favorite things. I
riddle the code with them in the interest of making it
smaller... surely it doesn't raise the barrier of
entry to understanding Ant's code _that_ much? :)
-Matt
>
> You've moved the // comments at the end of a block
> into the block. I'd
> prefer to just get rid of them altogether.
>
> Conor
>
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
> [EMAIL PROTECTED]
> For additional commands, e-mail:
> [EMAIL PROTECTED]
>
>
__________________________________
Do you Yahoo!?
Make Yahoo! your home page
http://www.yahoo.com/r/hs
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
