--- Stefan Bodewig <[EMAIL PROTECTED]> wrote:
> On Thu, 31 Mar 2005, Matt Benson
> <[EMAIL PROTECTED]> wrote:
> > --- Stefan Bodewig <[EMAIL PROTECTED]> wrote:
>
> >> Have you modified AbstractFileSet or the
> individual
> >> subclasses?
> >
> > Good question; I almost answered it in the
> original
> > mail. I figured we had little control over what
> > happens to AFS children so I implemented the new
> > interface in FileSet and DirSet directly.
>
> So ZipFileSet and ClassFileSet are not
> ResourceCollections right now?
Most *FileSet types actually extend FileSet. I forgot
to include ZipFileSet in the list of existing classes
I have updated, but I have and it is working as
expected. ClassFileSet IIRC should cleanly inherit
FileSet's ResourceCollection behavior based on my
inspection of the code. I will try to add that to my
unit tests.
>
> There certainly may be AFS children that are no good
> candidates for
> ResourceCollections so your choice seems logical,
> still people may
> expect to have a ResourceCollection when they extend
> AFS. Could be a
> matter of clear documentation.
Possibly, although since the AFS javadoc already would
NOT include ResourceCollection as an implemented
interface I'm not sure what else we could do besides
explicitly add a reminder of that fact. :)
>
> >> On Wed, 30 Mar 2005, Matt Benson
> >> <[EMAIL PROTECTED]> wrote:
>
> >> > 2) should there be a reference-only (resources)
> type that can
> >> > generically use a ResourceCollection of an
> unknown type?
> >>
> >> What would it be used for?
> >
> > The idea of "this task creates a
> ResourceCollection
> > with the specified reference." Okay, I invoke the
> > task, now I have a reference to an RC, but I don't
> > know its type, thus <resources refid="foo" />
>
> I see. So to answer your original question, yes, I
> think there should
> be one.
>
Thanks again,
Matt
(back to work!)
> Stefan
>
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
> [EMAIL PROTECTED]
> For additional commands, e-mail:
> [EMAIL PROTECTED]
>
>
__________________________________
Do you Yahoo!?
Make Yahoo! your home page
http://www.yahoo.com/r/hs
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
