if (condition) { return a; } return b;
over:
if (condition) { return a; } else { return b; }
Only real benefit is to get rid of compiler warnings. I'm ambivalent about either way being "more correct", but the fewer warnings I get the better IMHO, so I remove nesting of returns in else statements. I personally think that explicitly putting the else clause in helps legibility, but it's extra useless braces and it's unneccessary from teh compilers perspective. I always try to keep the compiler happy :)
so I didn't apply those patches.
No worries
I did apply the destDir -> baseDir one, but it left the javadoc in an inconsistent state (one would set destDir, but would get something based on baseDir), so I didn't commit that one.
Yeah this one was a pain too. I'm getting name hiding warnings from the compiler, the two options were to change each parameter in each method, or to change the member variable. I decided on the latter as it needed only one change instead of many.
Kev
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
