--- Stefan Bodewig <[EMAIL PROTECTED]> wrote:
> On Tue, 27 Sep 2005, Matt Benson
> <[EMAIL PROTECTED]> wrote:
>
> > I'd like to revisit this after your changes are
> > committed.
>
> Sure.
This was RE Copy/filesystem only. I agree that move
should work this way. We don't know how to move
non-file resources. We do know how to copy non-file
resources. I would think we could also sync them...
but that would be later. Now, accepting that we have
these protected ( >:( ) members to support, I suppose
my chosen approach would be to duplicate the file maps
as private resource maps w/ protected accessors.
Remove the check for filesystem-only, replace in
validateAttributes ONLY as a call to:
protected void validate(ResourceCollection rc) {
if (getClass().equals(Copy.class)
|| rc.isFilesystemOnly()) {
return;
}
throw new BuildException(
"Only filesystem resources are supported.");
}
}
Subclasses can override this when appropriate.
Then we change the copy logic to call some form of
FileUtils.copyResource().
Holes?
-Matt
__________________________________
Yahoo! Mail - PC Magazine Editors' Choice 2005
http://mail.yahoo.com
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
