DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=37169>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=37169 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO ------- Additional Comments From [EMAIL PROTECTED] 2005-10-21 21:20 ------- Sorry, I do hesitate to call somthing a bug, but changing a method to have a new execution speed orders of magnitude slower as before is generally considered a bug, even if the functional behaviour remains the same. In case this delay is mainly caused by swapping (because the change in the java environment memory consumption is slightly up) it need not be a bug, but may be just bad luck, an option I left explicitly open. Sun confirmed this bug in JDK 1.5 (see http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6219959) I indeed misread the sql to line change. StringBuffer sql may be appended to though, even after String line is added, so the proposed change is not equivalent to the original code. We get quite some proposed fixes/enhancements that use newer java features as available in jdk 1.2 Does changing the code to if ((delimiterType.equals(DelimiterType.NORMAL) && stringBufferEndsWith(sql,delimiter)) and introducing the method static boolean stringBufferEndsWith(StringBuffer b, String end) { if (b.length() < end.length()) { return false; } return (end.equals(b.substring(b.length()-end.length(),b.length()))); } fix the speed problem on jdk 1.5, yet keep the same behaviour? (in case it does I'll introduce this change) -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
