2 comments : 1) we could remove this particular test called testSystemId in TraXLiaisonTest, because it was calling a deprecated method, and JaxpUtils has its own test cases.
2) what worries me is that what we now get by calling FileUtils.toURI seems to start with file:/// under JDK 1.5 and file:/ under JDK 1.4. Is this good or bad ? or indifferent ? Not sure. Jesse Glick wrote [1] that file URIs should start with file:/ . the extra double slash being not needed. Antoine [1]http://issues.apache.org/bugzilla/show_bug.cgi?id=8031 [EMAIL PROTECTED] wrote: >Author: antoine >Date: Tue Dec 20 13:56:31 2005 >New Revision: 358117 > >URL: http://svn.apache.org/viewcvs?rev=358117&view=rev >Log: >Make the tests pass on Gump. > >Modified: > > ant/core/trunk/src/testcases/org/apache/tools/ant/taskdefs/optional/TraXLiaisonTest.java > >Modified: >ant/core/trunk/src/testcases/org/apache/tools/ant/taskdefs/optional/TraXLiaisonTest.java >URL: >http://svn.apache.org/viewcvs/ant/core/trunk/src/testcases/org/apache/tools/ant/taskdefs/optional/TraXLiaisonTest.java?rev=358117&r1=358116&r2=358117&view=diff >============================================================================== >--- >ant/core/trunk/src/testcases/org/apache/tools/ant/taskdefs/optional/TraXLiaisonTest.java > (original) >+++ >ant/core/trunk/src/testcases/org/apache/tools/ant/taskdefs/optional/TraXLiaisonTest.java > Tue Dec 20 13:56:31 2005 >@@ -3,6 +3,7 @@ > import org.apache.tools.ant.taskdefs.XSLTLiaison; > import org.apache.tools.ant.taskdefs.XSLTLogger; > import org.apache.tools.ant.BuildException; >+import org.apache.tools.ant.util.JAXPUtils; > > import java.io.File; > >@@ -86,8 +87,8 @@ > } else { > file = new File("/user/local/bin"); > } >- String systemid = ((TraXLiaison)liaison).getSystemId(file); >- assertTrue("SystemIDs should start by file:///", >systemid.startsWith("file:///")); >+ String systemid = JAXPUtils.getSystemId(file); >+ assertTrue("SystemIDs should start by file:/", >systemid.startsWith("file:/")); > assertTrue("SystemIDs should not start with file:////", > !systemid.startsWith("file:////")); > } > > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
