Hello, thanks for the patch, I have submitted parts of it.
What I have submitted is closing the HttpURLConnection in close(). The close method has become synchronised (not sure if it was necessary). When reading the contentlength, the connection is not closed after calling isExists(false). Calling close() after getContentLength() causes problems when running under JDK 1.5. Not under JDK 1.4. I did not look in the bugparade of Sun to try to understand why. So the new version of URLResource does not call close after getContentLength() and after getLastModified(). Nor after getOutputStream and getInputStream. Closing after getOutputStream made me fail a test where http://ant.apache.org is downloaded twice. I do not know why. This time the problem was under JDK 1.4 Regards, Antoine Xavier Hanin wrote: > On 9/20/06, Matt Benson <[EMAIL PROTECTED]> wrote: >> >> --- Antoine Levy-Lambert <[EMAIL PROTECTED]> wrote: >> >> > Hello Xavier, >> > >> > the patch is welcome, but I do not see the >> > attachment ? maybe it >> > comes from my email reader. >> >> Nor did I. :) > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
