Xavier Hanin wrote:
On 9/20/06, Matt Benson <[EMAIL PROTECTED]> wrote:
I have been thinking it might make sense to add
getURL() to Resource. Did a discussion on that
already take place? I don't remember if it was
generally thought to be a good idea...
And, for example, what would we do for resources of
nonstandard "protocols"? Would a StringResource with
value "foo" return "string:foo" as its URL? Should we
install custom protocol handlers for built-in
resources and encourage the same be done for
third-party resource implementations?
Actually this sounds like a good idea to me. Because
it seems to touch on the discussion we had before
about a string "encoding" to allow a Resource to be
specified as an attribute. We talked about whether a
"type:stringconstructorarg" scheme would work... but
if IH knew that setFoo(Resource r) meant to treat the
attribute string as a URL and we had custom protocol
handlers installed for the built-in Resource types,
that would be just as good, if not better (I'm not
forgetting we would have to special-case protocol-less
strings to be interpreted as files for BC).
I have no opinion about adding getURL () to Resource, but I think that
adding an easy way to encode/decode a resource to a string is really a
must!
And using a "type:" scheme is not really convenient IMHO. So using custom
URL scheme sounds like a very good idea!
If a Resource adds getURL()
1. do it now, before ant1.7 ships
2. add some tests for resources that return null
Speaking of which, we have an NPE in a copy if the resource doesnt have
a name:
<copy todir="${build.dir}">
<res:random size="8192"/>
</copy>
leads to
--- Nested Exception ---
java.lang.NullPointerException
at
org.apache.tools.ant.util.ResourceUtils.selectOutOfDateSources(Resour
ceUtils.java:156)
at
org.apache.tools.ant.util.ResourceUtils.selectOutOfDateSources(Resour
ceUtils.java:124)
at org.apache.tools.ant.taskdefs.Copy.buildMap(Copy.java:730)
at org.apache.tools.ant.taskdefs.Copy.scan(Copy.java:662)
at org.apache.tools.ant.taskdefs.Copy.execute(Copy.java:545)
at
org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:276)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.
java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces
sorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at
org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.jav
a:105)
I will file a bugrep. This is one of the things the antbook tests on
gump should catch (random is an example resource to create a stream of
randomness)
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
