>Log: >add @since tag, remove unthrowable constructor exception, and >shrink some stuff > >Modified: > >ant/core/trunk/src/main/org/apache/tools/ant/util/ConcatResourceInputSt ream.java > >@@ -104,16 +104,12 @@ > if (managingPc != null) { > managingPc.log(message, loglevel); > } else { >- if (loglevel > Project.MSG_WARN) { >- System.out.println(message); >- } else { >- System.err.println(message); >- } >+ (loglevel > Project.MSG_WARN ? System.out : >+ System.err).println(message); > } > }
> private int readCurrent() throws IOException { >- return (eof || currentStream == null) ? EOF : currentStream.read(); >+ return eof || currentStream == null ? EOF : >+ currentStream.read(); > } >Modified: > ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Concat.java >@@ -252,7 +252,7 @@ > * @since Ant 1.7 > */ > public void add(ResourceCollection c) { >- rc = (rc == null) ? new Resources() : rc; >+ rc = rc == null ? new Resources() : rc; > rc.add(c); > } What is the advantage apart from decreasing readability? Jan --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]