Stefan Bodewig wrote:
On Sat, 28 Oct 2006, Steve Loughran <[EMAIL PROTECTED]> wrote:
4. You can then pull in a web.xml file via the webxml attribute, or
via a nested fileset. In either case we say "Although needxmlfile is
false, a web.xml file was included " ... and point to the file that
was added.
Sounds good.
5. once you set needxmlfile=false, and omit the web.xml attribute,
you can pull in a WEB-INF/web.xml from a fileset. What if there is
1 match in the fileset? The first one added wins; there is no extra
warning message.
I'd prefer a warning about duplicates.
OK. IT will make the logic more complex, but can be done.
6. When updating an existing war file, if update=false and
needxmlfile=false, then things get complex. The problem here is that
there isnt a webxml file, so stuff from filesets get pulled in. but
dependency logic in the fileset checking engages first.
Where do you see a problem? I'd still see whether we add a web.xml
and treat the case similar to (4).
Welll its primarily that we won't warn about there being a web.xml file
even though one is not asked for, because the task wont even see that
there is a web.xml file.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
