On 12/13/06, Kevin Jackson <[EMAIL PROTECTED]> wrote:
> The code uses reflection so it should compile on jdk 1.5 and > work on jdk 1.6.I put a conditional compile in the build.xml file so that the hasfreespace code isn't even compiled on pre 1.6 jdks : <selector id="needs.jdk1.6+"> <or> <filename name="${condition.package}/HasFreeSpace*"/> <filename name="${util.package}/java16/*"/> </or> </selector>
eek, I did not see that.! The point of using reflection is to have the condition in the ant distro. I think that the test in build.xml should be removed, at least until we say that the ant distro should be compiled with java6. At the moment, the ant distro should be compile with java5, (we do allow using lower jvms to compile a sub-set of ant, however this is not a distro). Peter
In reality, HasFreeSpace can be compiled on java5 (and lower), I put this into the build previously and didn't take it out - that would prevent the build from compiling the new code for this release (as there are no docs either, I initially thought it would be better to not ship the actual compiled version for 1.7.0 and put this in to prevent that from happening) > The unittests should check for jdk 1.6 and ignore the test > if run on a jdk less that 1.6. I've just committed your recommended change to use <available> to skip the test on java5 and lower Kev --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
