On Sat, 24 Mar 2007, Matt Benson <[EMAIL PROTECTED]> wrote: > --- Stefan Bodewig <[EMAIL PROTECTED]> wrote: > >> On Fri, 23 Mar 2007, Matt Benson >> <[EMAIL PROTECTED]> wrote: >> > --- Stefan Bodewig <[EMAIL PROTECTED]> wrote:
>> Not that bad. IH already favor setters for anything that's not a >> string over a plain String setter. But IH already is a pretty >> complex beast ... > > Right, the whole thing is it favors those non-String > setters once, for good and all, at construction. So > by the time you're actually using it, under the > current implementation, your IH instance has already > made up its mind what type "src" is, and it would be > random if we don't at least go in and say Resource > trumps File. It would take more surgery to make IH > store e.g. a map of property names to (map of types to > AttributeSetters); currently it maps name directly to > AttributeSetter. Later in my post I already agreed it would be simpler to do it that way than try to resolve a ressource and fall back to File at the time we want to execute the setter. We agree by now. >> >> bikeshedding? 8-) > <http://www.freebsd.org/doc/en_US.ISO8859-1/books/faq/misc.html#BIKESHED-PAINTING> > > I've read that one. So I wonder what's the one I > said, You said: >> >> > However I'm not sure what the RIGHT "trigger character" is and >> >> > IMO this is the only outstanding question stopping us from adding >> >> > this feature to Ant. Which I read as "I'm, not sure what the right color of the bikeshed is and IMO this is the only outstanding question stopping us from building the bike". Again, I was joking. >> >> OK, what is left? "#", "="? Or >> >> "url(http://www.apache.org/)"? >> > >> > I kind of liked the parentheses thing when I saw it... >> > I wonder if it looks too much like a method call. >> >> parens might look strange when use in a regexp mapper, curly braces >> might be better and they don't even look like a method call. > > For arguments' sake :) {} appear to be used at least > in the java1.4 regexp package. But we're talking > about mapper RESULTS ("to" attr) so that narrows > things considerably. Maybe the choice of character(s) > will be a necessary evil in some contexts. 8-) So simply go ahead, implement the Ressource as an attribute stuff using your preferred trigger and maybe have a vote if anybody objects. Stefan --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]