As usual I lack the technological competence to vote on this part, so I've again concentrated on checking the legal requirements and infrastructire stuff.
So far I didn't find any issues, which means I'm +1 on the release. The only stuff flagged by RAT are some JQuery files, the generated package-list (I'll teach RAT to detect it as generated once the code has moved into the incubator), the MANIFEST which cannot hold the license info at the top and the *.patterns files. I'd probably add licenses to the two .patterns files in the source distro just to be complete (after the beta). A nit: since you don't distribute JSch in the source distribution you wouldn't need to add its license to your LICENSE file, but I understand that maintaining separate LICENSE files for bin-with-deps and the other distributions would be a pain. Some questions (maybe I should kick of a new thread here, too late) Are the jars intended as the jars that go into the repository or do you intend to distribute them via the normal download as well? The bin-with-deps distribution contains an ant-1.6.jar. Which x of 1.6.x is this? Why not 1.7.0? Is this an unmodified version of Ant's jar (I don't see the -launcher.jar)? Is your MANIFEST.MF hand-crafted or created by something like bnd? I ask because I think we should add OSGI information to Ant's jars as well but am a bit undecided on how to go about it. Stefan --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
