On 2010-03-02, Stefan Bodewig <bode...@apache.org> wrote:

> On 2010-03-02, Antoine Levy Lambert <anto...@gmx.de> wrote:

>>    [junit] Testcase:
>> testDifferentWindowsDrive(org.apache.tools.ant.taskdefs.ManifestClassPathTest):
>> FAILED

> Fails for me as well when using JDK 1.6 but not when using JDK 1.4 - I'm
> currently running the full testsuite with 1.6 to see whether there is
> anything else.

No, only the usual jspc errors that I see with 1.4 as well.

> It shouldn't matter whether there is any drive in D: or not, the test
> is supposed to see it cannot create a relative path from a file on C:
> to a drive on D: - no matter what those drives are.

That's wrong.  It uses getCanonicalPath and Windows may throw an
exception if you try this for a file on a drive that is not ready.

Because of this the test contains a guard

            try {
                new java.io.File("D:/").getCanonicalPath();
            } catch (java.io.IOException e) {
                System.out.println("drive d: doesn't exist or is not ready,"
                                   + " skipping test");
                return;
            }

which is triggered on Java 1.4.1 but not on Java 1.6.

If you insert a CD the test will pass.

I've modified the guard to actually try a file on the disk and it works
for 1.4.1 and 1.6 - and the test is not skipped and passes if you insert
a CD on both JDKs.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Reply via email to