Hi, Nicolas: [SNIP] > I looked into the code, it seems > org.apache.tools.ant.types.resources.Restrict is the culprit. It uses > BaseResourceCollectionWrapper which loads the entire underlying resource > collection. > I searched for the use of BaseResourceCollectionWrapper in Ant and I think > that this performance issue may also affect > org.apache.tools.ant.types.resources.SizeLimitCollection and > org.apache.tools.ant.types.resources.Tokens. > > I started to think about a fix but it seems non trivial. If I'm not mistaken > we would have to implement an iterator which should deal with an optionnal > cache and concurrency.
While it would be possible to reimplement Restrict's internal wrapper such that it would dynamically calculate the included resources while iterating, I don't see any way to do the same when the *size* of the collection is requested... > I am also worried about the isFilesystemOnly implementation in Restrict. > Should it return true if actually selected resources are files, or return > true if the entire set of candidates are files ? In the first case it would > make the iterator useless. > Typically the implementation of #isFilesystemOnly() in BaseResourceCollectionWrapper and BaseResourceCollectionContainer is a quick check whether the underlying collection/s is/are known to be entirely filesystem-based. If not, each resource is checked in turn until one is found that is *not* filesystem-based. The reason for the distinction is to provide a means of recognizing whether it should be possible to handle a given resourcecollection using a task that can only work with files. -Matt > Side note: I didn't checked that piece of script in as our Hudson instance > doesn't have Ant 1.8 installed. Not yet. I'll ask for it. > > Nicolas > > [1] http://ant.apache.org/manual/Types/resources.html#resourcelist > > PS: I started recently to intensively use loadresource and all the resource > related stuff in my build scripts, it is amazingly porwerful ! It reminds me > when I was 'pipelining' in cocoon ;) > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org > For additional commands, e-mail: dev-h...@ant.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
