Hello Charles,

thanks for proposing a patch.

I have read the patch and I see one area for improvement.

Your patch seems to assume that File URLs have exactly the same syntax like 
file system paths except the file: prefix to indicate the protocol.

You need to use URLDecoder or equivalent because a File URL will have some 
special characters encoded such as spaces replaced by %32.

 Regards,

Antoine

On Nov 11, 2013, at 1:51 PM, Charles Duffy wrote:

> This isn't actually so important for URLResolver itself, which can be 
> replaced with the FileSystem resolver at will -- but without this patch, one 
> can't get the unique behavior of the IBiblio resolver combined with useOrigin.
> 
> Feedback appreciated.
> <url-local-cache-support.diff>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
> For additional commands, e-mail: dev-h...@ant.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Reply via email to