Github user pyxide commented on the issue:
https://github.com/apache/ant/pull/30
Thank you for your positive review.
> remove part of the reflection logic for master as we target Java8 and
javax.script should be there
I really don't have a strong opinion on this point. I did the first
prototype with `javax.script` classes but used reflection to accommodate to the
rest of the code.
While adding some test units, I discovered that the BSF manager may
automatically compiles scripts.
Had the bsf library been on my Ant classpath before, I wouldn't have
developped this feature.
Should we compile the scripts by default ?
On another note, I added the `encoding` option on the other script
components that use
the `src` attribute (ScriptCondition, ScriptMapper, ScriptFilter,
ScriptSelector).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
