Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/34
- we dont use @author
- TestXmlHelper
-- if xPathExpression would be a String and the method compiles that for
itself,
reuse would be easier
-- XmlHelper would be a better name, because does not work only on tests.
-- result could be inlined
- IvyMakePomTest#testClassifier()
-- you dont use expectedPomArtifactIds for assertions. Do you want to
check
emptyness after the loop?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
