bodewig commented on PR #199: URL: https://github.com/apache/ant/pull/199#issuecomment-1446249553
I wonder what kind of `Resource` this is as `Resource#toString` is expected to only print the resource's name - and this is what the code here relied on. Looks as if `StringResource` printed its contents, but that seems wrong to me as there may be more places where code expects `toString` to not reveal the contents. Having said that, using `name` rather than `toString` here (and potentially more places) is the right thing to do in any case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
