bodewig commented on PR #210:
URL: https://github.com/apache/ant/pull/210#issuecomment-2322035548

   The Commons Compress code base has been seeded (among other things) by code 
originating from the Ant project. I used to be a committer (and release 
manager) for Commons Compress and served the Ant project in a similar role. 
When I ported changes from Commons Compress to Ant I mostly did so in order to 
port bug fixes or add new features also useful for Ant - like support for ZIP64.
   
   I have left the Commons project several years ago, I don't follow the 
Compress project anymore and so I stopped porting any changes.
   
   In the past I have strongly recommended people use Commons Compress rather 
than Ant's code for compression/archives as Ant's code really does not want to 
be a general purpose library for this. We deliberately wanted to support what 
is needed by Ant - but not more. Even though I haven't followed Compress in a 
long time I'd still hope the library is more useful than Ant's tar/zip/bzip2 
packages. I fully understand your third-party dependencies problem and am sad 
the project has chosen this route, but that's not my call anymore.
   
   So much for historical background. :-)
   
   One reason to not port any changes that are not used by an Ant task directly 
is that we'd have more code that we need to maintain. Nobody in the Ant project 
tracks Commons Compress for changes anymore, so if we port a bug it is likely 
to remain undetected and unfixed over here. This is even more true as Ant 
wouldn't use the code and wouldn't be exposed to such bugs itself at all.
   
   As far as I remember (and COMPRESS-191 supports that) this check is used to 
detect files as tar archives. It does not actually verify the checksum but only 
tries to remove a bunch of false positives. I don't really see where we'd use 
that in Ant.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Reply via email to