maartenc commented on code in PR #120:
URL: https://github.com/apache/ant-ivy/pull/120#discussion_r3405278410
##########
test/java/org/apache/ivy/core/module/descriptor/IvyMakePomTest.java:
##########
@@ -32,59 +27,61 @@
import org.apache.ivy.TestHelper;
import org.apache.ivy.ant.IvyMakePom;
import org.apache.ivy.util.TestXmlHelper;
+
import org.apache.tools.ant.Project;
-import org.junit.Before;
+
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.TemporaryFolder;
import org.w3c.dom.Node;
import org.w3c.dom.NodeList;
+import static org.apache.commons.io.FileUtils.readFileToString;
+import static org.apache.commons.io.FileUtils.writeLines;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertTrue;
+
/**
- * Tests {@link IvyMakePom}
+ * Tests {@link IvyMakePom}.
*/
public class IvyMakePomTest {
- private Project project;
+ private Project project = TestHelper.newProject();
@Rule
public TemporaryFolder workdir = new TemporaryFolder();
- @Before
- public void beforeTest() {
- this.project = TestHelper.newProject();
- }
-
/**
- * Test case for IVY-1528. An Ivy file containing a
<code>classifier</code> extra attribute in
- * its dependency, must retain the <code>classifier</code> in the
generated POM when converted
- * to a POM file through {@link IvyMakePom}.
- *
- * @throws Exception if something goes wrong
- * @see <a
href="https://issues.apache.org/jira/browse/IVY-1528";>IVY-1528</a>
+ * Test case for <a
href="https://issues.apache.org/jira/browse/IVY-1528";>IVY-1528</a>.
+ * <p>
+ * An Ivy file containing a <code>classifier</code> extra attribute in its
+ * dependency, must retain the <code>classifier</code> in the generated POM
+ * when converted to a POM file through {@link IvyMakePom}.
*/
@Test
- public void testClassifier() throws Exception {
- final File ivyFile = new
File(IvyMakePomTest.class.getResource("ivy-to-pom-classifier.xml").toURI());
+ public void testMakePom1528() throws Exception {
Review Comment:
why rename the test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
