nx-eric-jarosch commented on PR #3:
URL:
https://github.com/apache/ant-antlibs-cyclonedx/pull/3#issuecomment-7005358497
Hi @bodewig ,
the Exception that will be observed by `fillFromModuleDescriptor` is a
`BuildException` wrapping a `MalformedURLException`.
I could catch that and check the wrapped exception, but that seems hacky /
like I'm fighting with the API.
Looking at `org.apache.tools.ant.types.resources.ResourceList#parse`, that
does:
```java
try {
return new URLResource(expandedLine);
} catch (BuildException mfe) {
// a translated MalformedURLException
// probably it's an absolute path fall back to file
// resource
}
```
I could mirror that.
Then at least the BuildException thrown by
`org.apache.ant.cyclonedx.License#addConfiguredUrl` isn't swallowed.
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]