Hi Lewis,
Fair question - I'd rather see the issues at least discussed. I'm not
exactly sure what MIT requires here. Maybe the reference in the source
is enough; the fact that jquery.min breaks the strict wording of it's
own license is ironic.
Personally, I think that all relevant info should, briefly, be in NOTICE
or LICENSE not buried in files deep in the source tree so a mention is
good. But this is opinion, not requirement.
On the source files with missing headers, I'd rather they were fixed but
if people feel fix-now-for-next-time is sufficient, I'll not oppose that.
How bad was the release process? It didn't sound easy but if it is
redone, would it be easier?
What is blocking the release is votes. The silence in votes and
discussion on matters arising is a bit worrying.
Andy
On 08/05/13 19:27, Lewis John Mcgibbney wrote:
Hi Andy,
As always, thanks for the feedback on the release. Really helpful.
I wonder if you have formed an opinion as to whether you can VOTE or not?
There are obviously some pretty important issues within the number you have
flagged... are these blocking to the release?
Thanks Andy
Lewis
On Sat, May 4, 2013 at 8:19 AM, <[email protected]> wrote:
--
*Lewis*
Review of Any23 0.8.0 (vote called 2/5/2013)
- No license header on 3 source files.
- Not sure about NOTICE/LICENSE because MIT software included in source.
otherwise looks OK.
== Process
Signature on source release (zip and tar.gz): good
Build from git tag: yes
Build from source: yes
LICENSE and NOTICE:
NOTICE for the source-release file is minimal.
LICENSE is Apache only (assumes no inclusions of source from BSD e.g.
Sesame because BSD says:
"""
Redistributions of source code must retain the above copyright notice,
this list of conditions and the following disclaimer.
"""
)
** No license header on 3 source files:
./core/src/main/java/org/**apache/any23/extractor/csv/**
CSVExtractorFactory.java
./core/src/test/java/org/**apache/any23/extractor/**example/**
ExampleExtractorFactory.java
./plugins/office-scraper/src/**main/java/org/apache/any23/**
plugin/officescraper/**ExcelExtractorFactory.java
** JQuery is MIT:
./service/src/main/webapp/**resources/js/jquery-1.7.2.min.**js
which includes:
"""
The above copyright notice and this permission notice shall be
included in all copies or substantial portions of the Software.
"""
so I expected something in NOTICE and LICENSE because it is not in
jquery-1.7.2.min.js itself and this condition is inherited by any one
redistributing Any23.
== Other
+ DISCLAIMER is an empty file.
+ Top level LICENSE-header.txt is confusing - there is a real LICENSE.txt
as well (put in a subdirectory?)
