Github user ansell commented on a diff in the pull request:

    https://github.com/apache/any23/pull/42#discussion_r126826866
  
    --- Diff: 
core/src/test/java/org/apache/any23/extractor/yaml/YAMLExtractorTest.java ---
    @@ -93,4 +92,17 @@ public void nullTest()
             RepositoryResult<Statement> docs = getStatements(null, null, 
RDF.NIL);
             Assert.assertTrue(Iterations.asList(docs).size() == 2);
         }
    +
    +    /**
    +     * Comma separated values are parsed as well.
    +     *
    +     * @throws Exception
    +     */
    +    @Test
    +    public void csvTest()
    +            throws Exception {
    +        assertExtract("/org/apache/any23/extractor/csv/test-comma.csv");
    --- End diff --
    
    I am not familiar with YAML, but is CSV (RFC 4180 Section 2 and all other 
variations) a strict subset of YAML or is it incidental that this test file 
works with the YAML parser? If it is only incidental we shouldn't be testing it 
here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to