[ https://issues.apache.org/jira/browse/ANY23-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436466#comment-16436466 ]
ASF GitHub Bot commented on ANY23-167: -------------------------------------- GitHub user HansBrende opened a pull request: https://github.com/apache/any23/pull/74 ANY23-167 fixed: parent itemscopes inherited all properties from child itemscopes mvn clean test -> all tests pass (after modifying tests that were testing for incorrect behavior). You can merge this pull request into a Git repository by running: $ git pull https://github.com/HansBrende/any23 ANY23-167 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/any23/pull/74.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #74 ---- commit 8f0db89ea1c4ca1c9c59d740b5ee4fe687957e5a Author: Hans <firedrake93@...> Date: 2018-04-12T23:12:02Z ANY23-167 fixed: parent itemscopes inherited all properties from child itemscopes ---- > Microdata itemscope properties incorrectly attached > --------------------------------------------------- > > Key: ANY23-167 > URL: https://issues.apache.org/jira/browse/ANY23-167 > Project: Apache Any23 > Issue Type: Bug > Components: microdata > Reporter: Ruben Verborgh > Assignee: Hans Brende > Priority: Major > Labels: microdata > Fix For: 2.3 > > > In some cases, Microdata properties inside an itemscope are attached to the > parent object. > For instance: http://ruben.verborgh.org/tmp/schemaorg-test.html > http://any23.org/any23/?uri=http%3A%2F%2Fruben.verborgh.org%2Ftmp%2Fschemaorg-test.html > Note how a separate Person entity is recognized, > but property values themselves are attached to the BlogPosting entity instead > of the Person entity. > Also the properties familyName and givenName are incorrectly identified as > http://schema.org/BlogPosting/familyName and > http://schema.org/BlogPosting/givenName, > while they should be http://schema.org/familyName and > http://schema.org/givenName. > The Structured Data Testing Tool shows the correct interpretation: > http://www.google.com/webmasters/tools/richsnippets?q=http%3A%2F%2Fruben.verborgh.org%2Ftmp%2Fschemaorg-test.html > Also note the wrong name "http:/schema.orgPerson" instead of > "http:/schema.org/Person". This seems to happen because the quotes around the > attribute are missing in the HTML source (I can file another issue for that > if needed). -- This message was sent by Atlassian JIRA (v7.6.3#76005)