[
https://issues.apache.org/jira/browse/ANY23-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564046#comment-16564046
]
ASF GitHub Bot commented on ANY23-374:
--------------------------------------
GitHub user HansBrende opened a pull request:
https://github.com/apache/any23/pull/105
ANY23-374 fix schemeless microdata urls
Fixes microdata itemtype urls that are lacking a scheme by using a default
scheme of "http".
mvn clean test -> all tests passed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HansBrende/any23 ANY23-374
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/any23/pull/105.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #105
----
commit d283d70ceb692cacb1f31659ee5d5c987822028f
Author: Hans <firedrake93@...>
Date: 2018-07-31T17:21:26Z
ANY23-374 fix schemeless microdata urls
----
> Invalid nested item takes out everything
> ----------------------------------------
>
> Key: ANY23-374
> URL: https://issues.apache.org/jira/browse/ANY23-374
> Project: Apache Any23
> Issue Type: Improvement
> Components: extractors, microdata
> Affects Versions: 2.2
> Reporter: Anthony Pessy
> Priority: Minor
>
> I encountered an item such as:
> {code:java}
> <div itemscope itemtype="http://schema.org/Question";>
> <h3 itemprop="name">Name</h3>
> <div itemprop="acceptedAnswer" itemscope itemtype="schema.org/Answer">
> <p itemprop="text">Text</p>
> </div>
> </div>
> {code}
>
> Because of the invalid answer, it throws an `IllegalArgumentException` (not a
> `MicrodataParserException` !) and I do not even have the Question available.
> Now, because I let the default `FULL_REPORT` as `ErrorMode` I was expecting
> to have the question and `getErrors()` returning eventual encountered errors.
> Am I missing something?
>
> Edit:
>
> Note that Google testing tool is somehow not complaining (maybe it should?):
>
> https://search.google.com/structured-data/testing-tool/u/0/#url=https%3A%2F%2Froams.es%2Ffreedompop%2F
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
