[
https://issues.apache.org/jira/browse/ANY23-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585623#comment-16585623
]
ASF GitHub Bot commented on ANY23-388:
--------------------------------------
GitHub user larsgsvensson opened a pull request:
https://github.com/apache/any23/pull/117
ANY23-388 Make field writer and constructor protected
Make the constructor of `RDFWriterTripleHandler` and its field `writer`
protected, as
[discussed](https://issues.apache.org/jira/browse/ANY23-388?focusedCommentId=16580679&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16580679)
by me, @lewismc and @HansBrende. This replaces PR #116
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/larsgsvensson/any23 ANY23-388
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/any23/pull/117.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #117
----
commit e5562c5e49e6463c22dc598efcc16870b4c320cd
Author: larsgsvensson <lars.g.svensson@...>
Date: 2018-08-20T08:29:20Z
ANY23-388 made field writer and default constructor protected instead of
package private
----
> It should be possible to configure the NTriplesWriter to use unicode points
> ---------------------------------------------------------------------------
>
> Key: ANY23-388
> URL: https://issues.apache.org/jira/browse/ANY23-388
> Project: Apache Any23
> Issue Type: Improvement
> Components: core
> Affects Versions: 2.2
> Reporter: Lars G. Svensson
> Priority: Minor
> Fix For: 2.3
>
>
> When using the NTriplesWriter, I wanted to configure it to write unicode
> points as escape sequences. I tried to subclass
> org.apache.any23.writer.TripleHandler and overwrite the access to the
> org.eclipse.rdf4j.rio.ntriples.NTriplesWriter but couldn't do that since the
> access to the NTriplesWriter is package protected. I ended up copying the
> code which seems a bit clunky...
> I was [asked to create a pull
> request|https://mail-archives.apache.org/mod_mbox/any23-user/201808.mbox/%3CCAGaRif3KAQbnK6XSKnVUZAJOn8aR_iCmJmGv_L05yg6nBkB%3DwA%40mail.gmail.com%3E],
> this issue is there to track that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
