@HansBrende. Sorry, I did not follow your latest commits. My proof of concept was done for different approach so I thought it would be useless in your one. I had thought I would need to write the new one. But if you reused so I am happy of that. You have still my +1.
On Wed, 26 Sep 2018, 21:54 ASF GitHub Bot (JIRA), <[email protected]> wrote: > > [ > https://issues.apache.org/jira/browse/ANY23-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16629393#comment-16629393 > ] > > ASF GitHub Bot commented on ANY23-396: > -------------------------------------- > > Github user HansBrende commented on the issue: > > https://github.com/apache/any23/pull/122 > > @jgrzebyta thanks for your +1. Is the improved state of the javadoc to > your liking? > > > I will add my unit in a separate ticket. > > I'm confused: are you referring to your existing PR #121 ? This PR is > meant to be an alternative to that one. In my last commit, I have also > added your [`ExtractorsFlowTest`]( > https://github.com/apache/any23/blob/f95f23865c0a7088e4ab1cbe507b8457fc90dda5/cli/src/test/java/org/apache/any23/cli/ExtractorsFlowTest.java) > proof-of-concept to this PR to clarify that this PR provides at least as > much functionality as #121 does. The only difference being: this PR uses > the new `DelegatingWriterFactory` to accomplish the same behavior > previously provided by `ModelExtractor` in #121. So if you approve this PR, > my assumption would be that you prefer it over #121, and that #121 would be > discarded. > > Any additional comments or concerns? Do I still have your +1? > > > > > Add ability to run extractors in flow > > ------------------------------------- > > > > Key: ANY23-396 > > URL: https://issues.apache.org/jira/browse/ANY23-396 > > Project: Apache Any23 > > Issue Type: Improvement > > Components: core > > Affects Versions: 2.2 > > Reporter: Jacek Grzebyta > > Assignee: Jacek Grzebyta > > Priority: Minor > > > > Currently extractors do not work in flows. I.E. Next extractor has no > any access to triples made by previous one. > > It would be useful if an extractor has possibility to modify triples > created by another extractor. > > > > > > -- > This message was sent by Atlassian JIRA > (v7.6.3#76005) >
