HansBrende commented on a change in pull request #146: ANY23-426 Address Javadoc WARNING's URL: https://github.com/apache/any23/pull/146#discussion_r328410027
########## File path: api/src/main/java/org/apache/any23/configuration/Setting.java ########## @@ -113,6 +113,8 @@ public final Type getValueType() { } /** + * @param setting a setting key to retrieve + * @param <S> generic type for setting Review comment: Perhaps something more along the lines of: ``` @param setting a setting that may or may not have the same key as this setting @param <S> the type of the supplied setting ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services